Revert bumping samsam to v9 to fix buffer comparisons#2681
Closed
mattbaileyuk wants to merge 1 commit intosinonjs:mainfrom
Closed
Revert bumping samsam to v9 to fix buffer comparisons#2681mattbaileyuk wants to merge 1 commit intosinonjs:mainfrom
mattbaileyuk wants to merge 1 commit intosinonjs:mainfrom
Conversation
Contributor
|
|
Contributor
|
There will be patch coming today to address the fallout for Buffers in sinonjs/samsam#289 This happened because In the Node runtime, both buffers came from the same pooled parent ArrayBuffer of length 8192, and offset is just the start position of each view into that slab. I verified: So the contents are identical, but the internal slice position is different. That offset getter is inherited and enumerable on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose (TL;DR) - mandatory
Fixes #2678
Reverts
@sinonjs/samsamto v8 (as used before this commit bumped the package to v9)Background (Problem in detail)
Given the problems identified in the issue above around Buffer object comparisons (and as raised directly in sinonjs/samsam#289), this moves back to the previous major version of
samsamsosinoncan successfully do comparisons of Buffer objects.How to verify - mandatory
npm installChecklist for author
npm run lintpasses